work on removing communicator

src/communicator/__init__.py

@@ -86,14 +86,6 @@ class OnionrCommunicatorDaemon:
         # extends our upload list and saves our list when Onionr exits
         uploadqueue.UploadQueue(self)
 
-
-        # Set timers, function reference, seconds
-        # requires_peer True means the timer function won't fire if we
-        # have no connected peers
-        peerPoolTimer = OnionrCommunicatorTimers(
-            self, onlinepeers.get_online_peers, 60, max_threads=1,
-            my_args=[self])
-
         # Timers to periodically lookup new blocks and download them
         lookup_blocks_timer = OnionrCommunicatorTimers(
             self,
@@ -184,7 +176,6 @@ class OnionrCommunicatorDaemon:
             self, housekeeping.clean_keys, 15, my_args=[self], max_threads=1)
 
         # Adjust initial timer triggers
-        peerPoolTimer.count = (peerPoolTimer.frequency - 1)
         cleanupTimer.count = (cleanupTimer.frequency - 60)
         blockCleanupTimer.count = (blockCleanupTimer.frequency - 2)
         lookup_blocks_timer = (lookup_blocks_timer.frequency - 2)
@@ -193,7 +184,7 @@ class OnionrCommunicatorDaemon:
 
         if config.get('general.use_bootstrap_list', True):
             bootstrappeers.add_bootstrap_list_to_peer_list(
-                self, [], db_only=True)
+                self.kv, [], db_only=True)
 
         daemoneventhooks.daemon_event_handlers(shared_state)
 
@@ -257,11 +248,6 @@ class OnionrCommunicatorDaemon:
         except KeyError:
             pass
 
-    def connectNewPeer(self, peer='', useBootstrap=False):
-        """Adds a new random online peer to self.onlinePeers"""
-        connectnewpeers.connect_new_peer_to_communicator(
-            self, peer, useBootstrap)
-
     def peerCleanup(self):
         """This just calls onionrpeers.cleanupPeers.
 

src/communicator/bootstrappeers.py

@@ -4,9 +4,6 @@ add bootstrap peers to the communicator peer list
 """
 from typing import TYPE_CHECKING
 
-if TYPE_CHECKING:
-    from deadsimplekv import DeadSimpleKV
-
 from utils import readstatic, gettransports
 from coredb import keydb
 """
@@ -27,9 +24,8 @@ from coredb import keydb
 bootstrap_peers = readstatic.read_static('bootstrap-nodes.txt').split(',')
 
 
-def add_bootstrap_list_to_peer_list(comm_inst, peerList, db_only=False):
+def add_bootstrap_list_to_peer_list(kv, peerList, db_only=False):
     """Add the bootstrap list to the peer list (no duplicates)."""
-    kv: "DeadSimpleKV" = comm_inst.shared_state.get_by_string("DeadSimpleKV")
     for i in bootstrap_peers:
         if i not in peerList and i not in kv.get('offlinePeers') \
                 and i not in gettransports.get() and len(str(i).strip()) > 0:

src/communicator/onlinepeers/onlinepeers.py

@@ -5,11 +5,12 @@ get online peers in a communicator instance
 import time
 from typing import TYPE_CHECKING
 
+import config
 from etc.humanreadabletime import human_readable_time
+from communicatorutils.connectnewpeers import connect_new_peer_to_communicator
 import logger
 if TYPE_CHECKING:
     from deadsimplekv import DeadSimpleKV
-    from communicator import OnionrCommunicatorDaemon
 """
     This program is free software: you can redistribute it and/or modify
     it under the terms of the GNU General Public License as published by
@@ -26,17 +27,15 @@ if TYPE_CHECKING:
 """
 
 
-def get_online_peers(comm_inst: 'OnionrCommunicatorDaemon'):
+def get_online_peers(shared_state):
     """Manage the kv.get('onlinePeers') attribute list.
 
     Connect to more peers if we have none connected
     """
-    config = comm_inst.config
-    kv: "DeadSimpleKV" = comm_inst.shared_state.get_by_string("DeadSimpleKV")
+    kv: "DeadSimpleKV" = shared_state.get_by_string("DeadSimpleKV")
     if config.get('general.offline_mode', False):
-        comm_inst.decrementThreadCount('get_online_peers')
         return
-    logger.debug('Refreshing peer pool...')
+    logger.info('Refreshing peer pool...')
     max_peers = int(config.get('peers.max_connect', 10))
     needed = max_peers - len(kv.get('onlinePeers'))
 
@@ -46,9 +45,9 @@ def get_online_peers(comm_inst: 'OnionrCommunicatorDaemon'):
 
     for _ in range(needed):
         if len(kv.get('onlinePeers')) == 0:
-            comm_inst.connectNewPeer(useBootstrap=True)
+            connect_new_peer_to_communicator(shared_state, useBootstrap=True)
         else:
-            comm_inst.connectNewPeer()
+            connect_new_peer_to_communicator(shared_state)
 
         if kv.get('shutdown'):
             break
@@ -57,9 +56,8 @@ def get_online_peers(comm_inst: 'OnionrCommunicatorDaemon'):
             logger.debug('Couldn\'t connect to any peers.' +
                          f' Last node seen {last_seen}  ago.')
             try:
-                get_online_peers(comm_inst)
+                get_online_peers(kv)
             except RecursionError:
                 pass
         else:
             kv.put('lastNodeSeen', time.time())
-    comm_inst.decrementThreadCount('get_online_peers')

src/communicator/onlinepeers/removeonlinepeer.py

@@ -22,9 +22,8 @@ if TYPE_CHECKING:
 """
 
 
-def remove_online_peer(comm_inst, peer):
+def remove_online_peer(kv, peer):
     """Remove an online peer."""
-    kv: "DeadSimpleKV" = comm_inst.shared_state.get_by_string("DeadSimpleKV")
     try:
         del kv.get('connectTimes')[peer]
     except KeyError:

src/communicator/peeraction.py

@@ -2,11 +2,15 @@
 
 This file implements logic for performing requests to Onionr peers
 """
+from typing import TYPE_CHECKING
+
 import streamedrequests
 import logger
 from onionrutils import epoch, basicrequests
 from coredb import keydb
 from . import onlinepeers
+from onionrtypes import OnionAddressString
+from onionrpeers.peerprofiles import PeerProfiles
 """
     This program is free software: you can redistribute it and/or modify
     it under the terms of the GNU General Public License as published by
@@ -23,17 +27,27 @@ from . import onlinepeers
 """
 
 
-def peer_action(comm_inst, peer, action,
+def get_peer_profile(kv, address: OnionAddressString) -> 'PeerProfiles':
+    profile_inst_list = kv.get('peerProfiles')
+    for profile in profile_inst_list:
+        if profile.address == address:
+            return profile
+    p = PeerProfiles(address)
+    return p
+
+
+
+def peer_action(shared_state, peer, action,
                 returnHeaders=False, max_resp_size=5242880):
     """Perform a get request to a peer."""
     penalty_score = -10
-    kv: "DeadSimpleKV" = comm_inst.shared_state.get_by_string("DeadSimpleKV")
+    kv: "DeadSimpleKV" = shared_state.get_by_string("DeadSimpleKV")
     if len(peer) == 0:
         return False
     url = 'http://%s/%s' % (peer, action)
 
     try:
-        ret_data = basicrequests.do_get_request(url, port=comm_inst.proxyPort,
+        ret_data = basicrequests.do_get_request(url, port=kv.get('proxyPort'),
                                                 max_size=max_resp_size)
     except streamedrequests.exceptions.ResponseLimitReached:
         logger.warn(
@@ -44,14 +58,14 @@ def peer_action(comm_inst, peer, action,
     # if request failed, (error), mark peer offline
     if ret_data is False:
         try:
-            comm_inst.getPeerProfileInstance(peer).addScore(penalty_score)
-            onlinepeers.remove_online_peer(comm_inst, peer)
+            get_peer_profile(kv, peer).addScore(penalty_score)
+            onlinepeers.remove_online_peer(kv, peer)
             keydb.transportinfo.set_address_info(
                 peer, 'lastConnectAttempt', epoch.get_epoch())
             if action != 'ping' and not kv.get('shutdown'):
                 logger.warn(f'Lost connection to {peer}', terminal=True)
                 # Will only add a new peer to pool if needed
-                onlinepeers.get_online_peers(comm_inst)
+                onlinepeers.get_online_peers(kv)
         except ValueError:
             pass
     else: