based block size protection added

onionr/communicatorutils/downloadblocks/__init__.py

@@ -20,20 +20,7 @@
 import communicator, onionrexceptions
 import logger, onionrpeers
 from onionrutils import blockmetadata, stringvalidators, validatemetadata
-
-def _should_download(comm_inst, block_hash):
-    ret_data = True
-    if block_hash in comm_inst._core.getBlockList():
-        ret_data = False
-    else:
-        if comm_inst._core._blacklist.inBlacklist(block_hash):
-            ret_data = False
-    if ret_data is False:
-        try:
-            del comm_inst.blockQueue[block_hash]
-        except KeyError:
-            pass
-    return ret_data
+from . import shoulddownload
 
 def download_blocks_from_communicator(comm_inst):
     assert isinstance(comm_inst, communicator.OnionrCommunicatorDaemon)
@@ -47,13 +34,13 @@ def download_blocks_from_communicator(comm_inst):
             blockPeers = []
         removeFromQueue = True
 
-        if _should_download(comm_inst, blockHash):
+        if shoulddownload.should_download(comm_inst, blockHash):
             continue
 
         if comm_inst.shutdown or not comm_inst.isOnline or comm_inst._core.storage_counter.isFull():
             # Exit loop if shutting down or offline, or disk allocation reached
             break
-        # Do not download blocks being downloaded or that are already saved (edge cases)
+        # Do not download blocks being downloaded
         if blockHash in comm_inst.currentDownloading:
             #logger.debug('Already downloading block %s...' % blockHash)
             continue
@@ -67,7 +54,7 @@ def download_blocks_from_communicator(comm_inst):
 
         if not comm_inst.shutdown and peerUsed.strip() != '':
             logger.info("Attempting to download %s from %s..." % (blockHash[:12], peerUsed))
-        content = comm_inst.peerAction(peerUsed, 'getdata/' + blockHash) # block content from random peer (includes metadata)
+        content = comm_inst.peerAction(peerUsed, 'getdata/' + blockHash, max_resp_size=3000000) # block content from random peer (includes metadata)
         if content != False and len(content) > 0:
             try:
                 content = content.encode()

onionr/communicatorutils/downloadblocks/shoulddownload.py

@@ -0,0 +1,33 @@
+'''
+    Onionr - Private P2P Communication
+
+    Check if a block should be downloaded (if we already have it or its blacklisted or not)
+'''
+'''
+    This program is free software: you can redistribute it and/or modify
+    it under the terms of the GNU General Public License as published by
+    the Free Software Foundation, either version 3 of the License, or
+    (at your option) any later version.
+
+    This program is distributed in the hope that it will be useful,
+    but WITHOUT ANY WARRANTY; without even the implied warranty of
+    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+    GNU General Public License for more details.
+
+    You should have received a copy of the GNU General Public License
+    along with this program.  If not, see <https://www.gnu.org/licenses/>.
+'''
+def should_download(comm_inst, block_hash):
+    ret_data = True
+    if block_hash in comm_inst._core.getBlockList(): # Dont download block we have
+        ret_data = False
+    else:
+        if comm_inst._core._blacklist.inBlacklist(block_hash): # Dont download blacklisted block
+            ret_data = False
+    if ret_data is False:
+        # Remove block from communicator queue if it shouldnt be downloaded
+        try:
+            del comm_inst.blockQueue[block_hash]
+        except KeyError:
+            pass
+    return ret_data